[REF] extract getIdsOfMatchingContact #19172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
It seems this really needs sorting to be shared between the parser classes to fix up the error handling
eileenmcnaughton
force-pushed
the
dep_match
branch
from
05f6b55 to
a8ea392
Compare
| @@ -642,10 +634,6 @@ public function import($onDuplicate, &$values, $doGeocodeAddress = FALSE) { | |||
| if (isset($newContact) && is_a($newContact, 'CRM_Contact_BAO_Contact')) { | |||
| $relationship = TRUE; | |||
| } | |||
| elseif (is_a($error, 'CRM_Core_Error')) { | |||
There was a problem hiding this comment.
wasn't actually possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[REF] extract getIdsOfMatchingContact
It seems this really needs sorting to be shared between the parser classes
to fix up the error handling
Before
code in main block
After
code extracted
Technical Details
The function is only used by one class so far but 2 other classes can potentially share it
Comments