Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/financial#158 change UI parts of contribution soft schema to soft credit #19085

Merged
merged 1 commit into from
Dec 11, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Dec 1, 2020

Overview

Through out the ContributionSoft.xml fields are referred to as 'Contribution Soft x' but in the UI we normally use 'Soft Credit'
When exposing these fields through Search Kit/ Afform / Metadata based functions I believe 'Soft Credit' is more meaningful

Per https://lab.civicrm.org/dev/financial/-/issues/158

Before

e.g.
<title>Soft Contribution Amount</title>

After

<title>Soft Credit Amount</title>

Technical Details

I think we did talk about having 2 titles - one for context specific places & one for non-context aware places - that might make sense

Comments

Note I've only done the xml so far - will regenerate if agreed and / or merged

@civibot
Copy link

civibot bot commented Dec 1, 2020

(Standard links)

@civibot civibot bot added the master label Dec 1, 2020
@seamuslee001
Copy link
Contributor

This makes sense to me

@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 this was in the dev digest a week ago so I think we can take that as no dissent

@seamuslee001
Copy link
Contributor

Agreed can you run ./setup.sh -g please and then we can merge

@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 done

@seamuslee001
Copy link
Contributor

Jenkins re test this please

@seamuslee001 seamuslee001 merged commit 14730b9 into civicrm:master Dec 11, 2020
@seamuslee001 seamuslee001 deleted the words branch December 11, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants