dev/core#1931 Prevent PayPal from double-encoding the IPN Notify URL 5.32 backport #18996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
as per #18980 (comment) adding MOP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Solves this issue on the Lab.
Backport of #18980
Before
PayPal IPN return URLs contain double-encoded entities, e.g.
After
PayPal IPN return URLs do not contain double-encoded entities, e.g.
Technical Details
When CiviCRM does not use Clean URLs (or, in WordPress, if a Shortcode is used for a Contribution Page) then IPN notifications fail to register contributions as "Completed". This applies to all CMSes where Clean URLs are not in use.