(WIP) dev/core#2141 - OAuth2 exploratory branch

[totten]

Overview

This PR is to provide testing while the branch goes through rapid change. The aim will be to split out some parts within the week.

See also: https://lab.civicrm.org/dev/core/-/issues/2141

Before

What is the old user-interface or technical-contract (as appropriate)?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

After

What changed? What is new old user-interface or technical-contract?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

Technical Details

If the PR involves technical details/changes/considerations which would not be manifest to a casual developer skimming the above sections, please describe the details here.

Comments

Anything else you would like the reviewer to note

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

fail is on style warnings

[stesi561]

Attempting to r-run.
Enabled extension via api3
head to civicrm/admin/oauth#!/
Don't see any options to select.
Don't see any errors on console.
Don't see any errors in ConfigAndLog or watchdog - there is an info that seems to be dumping civicrm_views_tokens into Civicrm ConfigAndLog

[demeritcowboy]

Do you just see a blank screen? It should look like this. I see it's not obvious that those words are links until you hover. I just have a habit of clicking on things even if I'm not supposed to... So just click on where it says Google Mail for example.

[stesi561]

Sorry had taken a screenshot but forgot to attach!
I'm wondering if I need to include something else - I just applied -> https://patch-diff.githubusercontent.com/raw/civicrm/civicrm-core/pull/18863.patch

[stesi561]

I do see -> <!-- ngRepeat: provider in theProviders --> in the table body?

[demeritcowboy]

You're running 5.31 and then applying this patch? I'm running master which has some of this in it, and then just applied that one other patch about the button.

[stesi561]

Yes tried applying it to the RC.

[demeritcowboy]

There might be some supporting stuff in 5.32/master that it needs. To be honest not sure - I think most of this PR is in 5.32/master. There was a really short flurry of merges in the last two days.

[totten]

@stesi561 Yeah, for 5.31 backport, there are probably more patches. In addition to the OAuth-specific patches, it likely needs at least #18731. (The screen with the missing data relies on that patch.)

[totten]

I'm wondering if I need to include something else - I just applied -> https://patch-diff.githubusercontent.com/raw/civicrm/civicrm-core/pull/18863.patch

Oops, I didn't communicate clearly enough. :( During the previous week, I was rebasing this PR whenever bits were merged into master (5.32). Therefore, the URL above will give you the combination of all unmerged patches rather than the combination of all accumulated (merged or unmerged) patches.

For anything prior (eg 5.31-rc), one needs to backport all the PRs individually.

Since #18914 was merged into 5.32-master yesterday, we only have one more patch to merge (#18911). All of these will be in 5.32-rc (upcoming).

[eileenmcnaughton]

@totten just a reminder that this is kinda close to the point where it should be closed

[totten]

Everything in that was in this branch has either been merged in more focused PRs - or sent off to live the docs/issue-tracker.