Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/user-interface#34 Replace <th> with <td> on ContributionPage configuration Amount tab #18850

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

aydun
Copy link
Contributor

@aydun aydun commented Oct 23, 2020

Overview

See https://lab.civicrm.org/dev/user-interface/-/issues/34
Other ContributionPage tabs don't use <th> so switch to <td> for consistency to make styling easier.

Before

The rendering of <th> depends on the theme in use. Example here using Seven on Drupal 7:

image

After

image
Consistent with other tabs of configuration page

@civibot
Copy link

civibot bot commented Oct 23, 2020

(Standard links)

@civibot civibot bot added the master label Oct 23, 2020
@mattwire
Copy link
Contributor

Thanks @aydun

@mattwire mattwire merged commit 7606941 into civicrm:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants