dev/core#2024 extra line item issue on membership renewal

[eileenmcnaughton]

Overview

This fixes a bug where a random line item is created on the renewal form if the contribution has
tax but the amount is 0

Before

See https://lab.civicrm.org/dev/core/-/issues/2024

After

Only 1 line created

Technical Details

Alternative to #18526 - while I could see the case for that it turned out the breakage on this form stemmed from these lines....

   //Remove `tax_amount` if it is not calculated.
      // ?? WHY - I haven't been able to figure out...
      if (CRM_Utils_Array::value('tax_amount', $temporaryParams) === 0.0) {
        unset($temporaryParams['tax_amount']);
      }

which really make their own case for removal

Comments

I renamed a test function which caused a bit of noise

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

CRM_Member_Form_MembershipRenewalTest.testSubmitPayLaterCRM_Member_Form_MembershipRenewalTest.testSubmitPayLater

[seamuslee001]

This seems fine to me, I think we have sufficient test coverage to tell us if something is going wrong here merging