More buttonrama fallout

[eileenmcnaughton]

Overview

Fixes a notice from Buttonrama - affects 5.31+

Before

After

poof

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

I don't think this is the same as with static. This seems like an instance where it should be passing an array but isn't:

civicrm-core/CRM/Import/Form/DataSource.php

Line 53 in 39610e8

$this->add('File', 'uploadFile', ts('Import Data File'), 'size=30 maxlength=255', TRUE);

And in fact here I would just pass NULL instead since size and maxlength don't mean much for file upload fields.

[eileenmcnaughton]

@demeritcowboy Ah - ok - I assumed but yeah - let's fix to pass an array

[eileenmcnaughton]

Fixed

[demeritcowboy]

There's a double-space that snuck in there but otherwise looks good. Could also pass NULL since those html params don't mean much for file uploads. It didn't seem to make a difference when I tested.

[eileenmcnaughton]

@demeritcowboy OK - I went with NULL

[demeritcowboy]

Looks good!