dev/core#2066 Further cleanup on search actions #18783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
Most of the noise is in the shared pre-process code so my focus is on paring that down
eileenmcnaughton
force-pushed
the
distinct
branch
from
cc9e2a8 to
ab3e9e4
Compare
|
Sure, will let you know shortly. |
|
Tested the patch on test build site http://core-18783-koxl.test-1.civicrm.org:8001/ (admin / wJomS5aKsPpG) . Checked on each entity export and confirmed there is no breakage due to cleanup changes. Reviewed the code. Looks good. Merging now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Code cleanup - reduce complexity in task classes
Before
Lots of 'guesswork' on the form
After
Values set on the class
Technical Details
@monishdeb are you able to look at this - there are some others related which you could maybe test together
https://github.com/civicrm/civicrm-core/pulls?q=is%3Apr+is%3Aopen+2066
Comments
Requires this regression fix before it can be reviewed tested
Also ping @JoeMurray