Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Replace long if block with early return #18747

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Oct 12, 2020

Overview

All the functional code in this function is within an if - this removes that & uses an early return if not instead

Before

if ($x_subscription_id) {
 .. do the stuff
}

After

if (!$x_subscription_id) {
  return;
}
 .. do the stuff

Technical Details

Comments

@civibot
Copy link

civibot bot commented Oct 12, 2020

(Standard links)

@civibot civibot bot added the master label Oct 12, 2020
@eileenmcnaughton eileenmcnaughton merged commit 3ea17d1 into civicrm:master Oct 13, 2020
@eileenmcnaughton eileenmcnaughton deleted the aip2 branch October 13, 2020 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants