Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/financial#152 simplify passed parameters #18744

Merged
merged 1 commit into from
Oct 12, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Alter function signature to make the function's requirements clearer

Before

public function recur($input, $ids, $objects, $first) {
    $recur = &$objects['contributionRecur'];
    $contribution = &$objects['contribution'];

After

public function recur($input, $ids, $objects, $first) {

Technical Details

Rather than passing objects this switches to specifically passing the 2 objects being used in
the recur function

Comments

Rather than passing objects this switches to specifically passing the 2 objects being used in
the recur function
@civibot
Copy link

civibot bot commented Oct 12, 2020

(Standard links)

@civibot civibot bot added the master label Oct 12, 2020
@seamuslee001 seamuslee001 merged commit 93e3518 into civicrm:master Oct 12, 2020
@seamuslee001 seamuslee001 deleted the aip branch October 12, 2020 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants