dev/core#2096 Fix in-master-only regression on creating new events

[eileenmcnaughton]

Overview

unreleased regression - master branch - Creating a new event without an email produces Mandatory values missing from Api4 Email::save: email failure

Reproduction steps

1. Click on Events -> New Event.
2. Enter mandatory fields Event Type, Default Role, Event Title and Start and click Continue.
3. Observe Email is not required
4. Click Save and Done

Before

Error: Mandatory values missing from Api4 Email::save: email

After

No error!

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[aydun]

• General standards
  • (r-explain) Pass
  • (r-user) Pass:
  • (r-doc) Pass
  • (r-run) Pass: Tested on build test site. Scenario in ticket is fixed. But found another bug relating to address (will document shortly)
• Developer standards
  • (r-tech) Pass:
  • (r-code) Pass
  • (r-maint) Pass
  • (r-test) Undecided Someone once said tests were a good idea :-)

[totten]

Thanks @aydun!

(r-run) Pass: Tested on build test site. Scenario in ticket is fixed. But found another bug relating to address (will document shortly)

Cool.

(r-test) Undecided Someone once said tests were a good idea :-)

:)

I'll merge it - we're supposed to branch for 5.31-rc right... about... now... Since this is a very-recent (same-version) regression, it's easier if we get it in before branching.

Aside: I also did a bit of review. The only bit to add -- I grepped a bit on the affected class, and it only appears to affect this one use-case ("Edit Event"), so not concerned about side-effects. ✔️

[aydun]

Other bug is https://lab.civicrm.org/dev/core/-/issues/2102