Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#2073 Fix use of legacy leaky method in tested code #18699

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Oct 7, 2020

Overview

Fix use of legacy leaky method in tested code

Before

$columnsResult = $db->query($columnsQuery);

After

$columnsResult = CRM_Core_DAO::executeQuery($columnsQuery);

Technical Details

This is too low volume to really leak but it uses the leaky legacy method and
has test cover in

CRM_Contact_Import_Form_MapFieldTest.testSubmit with data set basic_data
CRM_Contact_Import_Form_MapFieldTest.testSubmit with data set save_mapping

Comments

@civibot
Copy link

civibot bot commented Oct 7, 2020

(Standard links)

@seamuslee001
Copy link
Contributor

Test fails relate @eileenmcnaughton

@eileenmcnaughton
Copy link
Contributor Author

Interesting - I didn't hit them locally - will look

This is too low volume to really leak but it uses the leaky legacy method and
has test cover in

CRM_Contact_Import_Form_MapFieldTest.testSubmit with data set basic_data
CRM_Contact_Import_Form_MapFieldTest.testSubmit with data set save_mapping
@eileenmcnaughton
Copy link
Contributor Author

Ah I did miss something off - should be fine now

@eileenmcnaughton eileenmcnaughton merged commit 8878666 into civicrm:master Oct 7, 2020
@eileenmcnaughton eileenmcnaughton deleted the leak5 branch October 7, 2020 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants