dev/core#2079 [REF] clean up call to apiQuery #18665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
test this please |
1 similar comment
|
test this please |
This fixes
1) fixes apiQuery to be called statically as it is a static function
2) casts results directly to detail
This is the copy & paste source of civicrm#18664 I guess....
eileenmcnaughton
force-pushed
the
list2
branch
from
3862202 to
64c57b7
Compare
|
Change looks fine and should have adequate test coverage here merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
dev/core#2079 [REF] clean up call to apiQuery
Before
static method called non-statically.
results put into
$detailskeyed as $details[0] & referenced as $details[0]After
results put into
$details& referenced as ``$details```Technical Details
This is the copy & paste source of #18664 I guess....
Comments
Code cover in CRM_Contact_Form_Task_PrintMailingLabelTest::testMailingLabel