Fix customGroup getTableNameByEntityName to recognize all entities

[colemanw]

Overview

This fixes a bug reported in https://www.drupal.org/project/webform_civicrm/issues/3172201

Before

Not possible via APIv3 to retrieve file attachments from Cases or other entities not in the hardcoded list.

After

Hardcoded list removed; all entities supported.

Technical Details

Code comment suggests that the hardcoded list was part of some early prototyping for the Attachment api. It has since been superseded by a function in CRM_Core_DAO_AllCoreTables which does in a more complete way what it was trying to do.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

Thanks this should also fix https://lab.civicrm.org/dev/core/-/issues/1988

[eileenmcnaughton]

Only called from one place that should have solid test cover

I was initially worried that there is a separate function which specifies which BAO support custom fields, and that the apiv3 relies on this being hard-coded but I find it is separate -

    // If we have custom fields the BAO may have taken care of it or we may have to.
    // $extendsMap provides a pretty good hard-coded list of BAOs that take care of the custom data.
    if (isset($params['custom']) && empty(CRM_Core_BAO_CustomQuery::$extendsMap[$entity])) {
      CRM_Core_BAO_CustomValueTable::store($params['custom'], CRM_Core_DAO_AllCoreTables::getTableForClass(CRM_Core_DAO_AllCoreTables::getFullName($entity)), $bao->id);
    }