Make it obvious that we are only passing payment_processor_id to loadRelatedObjects

[mattwire]

Overview

Partial from #18313. Pass only the required params to loadRelatedObjects for complete/repeattransaction

Before

Passing $input array.

After

Passing specific parameters

Technical Details

Comments

@eileenmcnaughton I tried moving loadRelatedObjects to _ipn_process_transaction but that causes problems because we mess with (unset some bits) the contribution object before passing and that breaks it. This is a simple cleanup that will probably help us remove the call entirely.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@mattwire why not just pass $input['payment_processor_id'] to completeOrder & skip loadRelatedObjects altogether? contribution & payment processor are the only objects passed in now & the 2 processors that call his could easily be adapted to pass in $input['payment_processor_id']. For the last place (#18479) we shouldn't pass it in at all

I think logically payment_processor_id is an input param - ie it's a piece of information we know at payment time about how the payment is happening

[mattwire]

@eileenmcnaughton Makes sense - see #18528