dev/core#2043 remove pass-by-reference

[eileenmcnaughton]

Overview

dev/core#2043 remove pass-by-reference

Rationale in https://lab.civicrm.org/dev/core/-/issues/2043

Before

public static function create($blockName, &$params, $entity = NULL, $contactId = NULL) {

After

public static function create($blockName, $params, $entity = NULL, $contactId = NULL) {

Technical Details

With #18484 committed it's fairly easy to see $params is not altered in this function

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@colemanw this should be easy now...