dev/core#1921 remove isoToMysql #18457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overview ---------------------------------------- Remove unnecessary isoToDate function Before ---------------------------------------- Code compatible with packages code of 6 years ago After ---------------------------------------- will break if you revert 6 year old fix.... Technical Details ---------------------------------------- The test testMailerStats passes through this line of code - which I think is probably about the most we can confirm testing wise as we expect there to be no reason to cast to mysql anymore Comments ---------------------------------------- https://lab.civicrm.org/dev/core/-/issues/1921
|
(Standard links)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove unnecessary isoToDate function
Before
Code compatible with packages code of 6 years ago
After
will break if you revert 6 year old fix....
Technical Details
The test testMailerStats passes through this line of code - which
I think is probably about the most we can confirm testing wise as we expect there
to be no reason to cast to mysql anymore
Comments
https://lab.civicrm.org/dev/core/-/issues/1921