Search extension: edit smart groups

[colemanw]

Overview

Allows the search extension to edit smart groups.
Tweaks the "Edit smart group criteria" links to point to either classic search forms or the new search extension, as appropriate.

Before

Could create smart groups from search extension but not easily edit them.

After

Edit button links from group to search extension, which displays the name of the group being edited and a button to update the criteria.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@colemanw - I tried this backported to 5.30 & also on master & I'm seeing this

[eileenmcnaughton]

Very UI - OK without test

[colemanw]

@eileenmcnaughton was there a console error? Backport might be missing some other needed thing in master.

[eileenmcnaughton]

@colemanw that screen shot was from master not my backport attempt - I have cividiscount installed on master & an extension with custom v4 apis on my wmf - not sure if that relates - it's after I add a field

[eileenmcnaughton]

I don't know if it relates but if I search on discounts I see fields that are not related to discounts

[eileenmcnaughton]

@colemanw I double checked by going to the test install - if I go to

http://core-18431-82ayt.test-1.civicrm.org:8001/civicrm/search#/create/Contact/

& switch to entity = Country & add a field it falls over

[colemanw]

@eileenmcnaughton thanks for testing. It should be fixed now.

[eileenmcnaughton]

I just tried to test on the demo site but it's not loading - I think the issue is unrelated

[eileenmcnaughton]

I gave this an r-run locally - the issues above seems to affect all demo sites from today but is not present locally.

I created a group

I was then able to reload it through

I think this is mergeable as it achieves what it is trying to achieve - but @colemanw I think there is an additional requirement in general to save searches & reload them when smartgroups cannot be created - should we open a GL to track that?

[colemanw]

@eileenmcnaughton yes I'd like to discuss other uses for SavedSearches with you.