Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

class.api.php: In remote api calls, allow referer and useragent to be set. #18400

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

aydun
Copy link
Contributor

@aydun aydun commented Sep 7, 2020

Overview

Update api/class.api.php to allow referer and useragent strings to be specified in the curl calls.
Some software (eg WordFence) blocks call without referer and useragent. This change allows these values to be set.

Before

referer and useragent cannot be set.

After

referer and useragent can be set.

Technical Details

This file is not used by core but is copied into some extensions. The change has no effect until copied by extension authors.

Some software (eg WordFence) blocks call without referer and useragent.
@civibot
Copy link

civibot bot commented Sep 7, 2020

(Standard links)

@civibot civibot bot added the master label Sep 7, 2020
@eileenmcnaughton
Copy link
Contributor

test this please

@eileenmcnaughton
Copy link
Contributor

@seamuslee001 this seems fairly neutral to me - thoughts?

@eileenmcnaughton
Copy link
Contributor

@kcristiano @lcdservices both of you gave this the thumbs up - do either of you want to say 'please merge this' ....

@kcristiano
Copy link
Member

@aydun I took a look at reviewing and testing. Do you know of an extension that I could use to test with the new params?

@seamuslee001
Copy link
Contributor

This looks fine to me merging

@seamuslee001 seamuslee001 merged commit 14033e0 into civicrm:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants