Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test whether line is hit #18382

Closed
wants to merge 1 commit into from
Closed

Test whether line is hit #18382

wants to merge 1 commit into from

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Sep 5, 2020 •
edited
Loading

Overview

OK to close with test failure info when finished

Before

After

Technical Details

Comments

@civibot
Copy link

civibot bot commented Sep 5, 2020

(Standard links)

@civibot civibot bot added the master label Sep 5, 2020
@eileenmcnaughton
Copy link
Contributor Author

api_v3_ContributionPageTest.testSubmitMembershipBlockIsSeparatePaymentPaymentProcessorNowChargesCorrectAmounts with data set #0
api_v3_ContributionPageTest.testSubmitMembershipBlockIsSeparatePaymentPaymentProcessorNowChargesCorrectAmounts with data set #1
api_v3_ContributionPageTest.testSubmitRecurMultiProcessorInstantPayment
api_v3_ContributionPageTest.testSubmitMembershipBlockNotSeparatePaymentProcessorInstantRenew
api_v3_ContributionPageTest.testSubmitMembershipBlockNotSeparatePaymentWithEmail
api_v3_ContributionPageTest.testSubmitMembershipBlockNotSeparatePaymentZeroDollarsWithEmail
api_v3_ContributionPageTest.testSubmitMembershipBlockIsSeparatePaymentWithEmail
api_v3_ContributionPageTest.testSubmitMembershipBlockIsSeparatePaymentPaymentProcessorNow
api_v3_ContributionPageTest.testSubmitMembershipPriceSetPaymentPaymentProcessorRecurInstantPaymentYear
api_v3_ContributionPageTest.testSubmitMembershipPriceSetPaymentPaymentProcessorRecurInstantPaymentMonth
api_v3_ContributionPageTest.testSubmitMembershipComplexNonPriceSetPaymentPaymentProcessorRecurInstantPayment
api_v3_ContributionPageTest.testSubmitMembershipComplexPriceSetPaymentPaymentProcessorRecurInstantPayment
api_v3_ContributionPageTest.testSubmitMembershipPriceSetPaymentPaymentProcessorSeparatePaymentRecurInstantPayment
api_v3_ContributionPageTest.testSubmitMembershipPriceSetPaymentPaymentProcessorRecurDelayed
api_v3_ContributionPageTest.testSubmitMembershipIsSeparatePaymentNotRecur
api_v3_ContributionPageTest.testSubmitPledgePaymentPaymentProcessorRecurFuturePayment
api_v3_ContributionPageTest.testSubmitPledgePayment
api_v3_ContributionTest.testRepeatTransactionMembershipRenewContributionNotCompleted with data set #1
api_v3_ContributionTest.testRepeatTransactionMembershipRenewContributionNotCompleted with data set #2
api_v3_ContributionTest.testRepeatTransactionMembershipRenewContributionNotCompleted with data set #3
api_v3_ContributionTest.testRepeatTransactionMembershipRenewContributionNotCompleted with data set #5
api_v3_ContributionTest.testRepeatTransactionMembershipRenewContributionNotCompleted with data set #6
api_v3_ContributionTest.testRepeatTransactionMembershipRenewContributionNotCompleted with data set #8
api_v3_ContributionTest.testRepeatTransactionMembershipRenewContributionNotCompleted with data set #9
api_v3_ContributionTest.testRepeatTransactionMembershipRenewContributionNotCompleted with data set #10
api_v3_ContributionTest.testCompleteTransactionSetStatusToInProgress with data set #0
api_v3_ContributionTest.testCompleteTransactionSetStatusToInProgress with data set #1
api_v3_ContributionTest.testCompleteTransactionSetStatusToInProgress with data set #2
api_v3_ContributionTest.testCompleteTransactionSetStatusToInProgress with data set "receive_date_includes_time"
api_v3_ContributionTest.testRepeatTransactionUpdateNextSchedContributionDate with data set "receive_date_includes_time_with_installments"
api_v3_ContributionTest.testRepeatTransactionUpdateNextSchedContributionDate with data set "receive_date_includes_time_no_installments"
api_v3_ContributionTest.testRepeatTransaction
api_v3_ContributionTest.testRepeatTransactionWithCustomData
api_v3_ContributionTest.testRepeatTransactionLineItems
api_v3_ContributionTest.testRepeatTransactionIsTest
api_v3_ContributionTest.testRepeatTransactionPassedInStatus
api_v3_ContributionTest.testRepeatTransactionAcceptRecurID
api_v3_ContributionTest.testRepeatTransactionTestRecurId
api_v3_ContributionTest.testRepeatTransactionMembershipRenewCompletedContribution
api_v3_ContributionTest.testRepeattransactionRenewMembershipOldMembership
api_v3_ContributionTest.testRepeatTransactionAlteredAmount
api_v3_ContributionTest.testRepeatTransactionPassedInFinancialType
api_v3_ContributionTest.testRepeatTransactionPassedInFinancialTypeTwoLineItems
api_v3_ContributionTest.testRepeatTransactionUpdatedFinancialType
api_v3_ContributionTest.testRepeatTransactionPassedInCampaign
api_v3_ContributionTest.testRepeatTransactionUpdatedCampaign
api_v3_ContributionTest.testRepeatTransactionUpdatedFinancialTypeAndNotEquals
api_v3_ContributionTest.testCompleteTransactionForRecurring
api_v3_ContributionTest.testCompleteTransactionMembershipPriceSetTwoTerms
api_v3_ContributionTest.testRepeatTransactionWithNonCreditCardDefault
api_v3_ContributionTest.testRepeatTransactionMembershipCreatePendingContribution
api_v3_ContributionTest.testSendMailWithRepeatTransactionAPIFalltoDomain
api_v3_ContributionTest.testSendMailWithRepeatTransactionAPIFalltoContributionPage
api_v3_ContributionTest.testSendMailWithRepeatTransactionAPIFalltoSystemFromNoDefaultFrom
api_v3_ContributionTest.testRepeatTransactionWithDifferenceCurrency
api_v3_ContributionTest.testRepeatContributionWithTaxAmount
CRM_Contribute_BAO_ContributionRecurTest.testGetTemplateContributionNewTemplate
CRM_Contribute_BAO_ContributionRecurTest.testAutoRenewalWhenOneMemberIsDeceased
CRM_Contribute_Form_Contribution_ConfirmTest.testPaynowPayment
CRM_Contribute_Form_ContributionTest.testSubmitCreditCardPayPal
CRM_Contribute_Form_ContributionTest.testSubmitCreditCardWithEmailReceipt
CRM_Contribute_Form_ContributionTest.testSubmitCreditCardNoReceipt
CRM_Contribute_Form_ContributionTest.testSubmitCreditCardFee
CRM_Contribute_Form_ContributionTest.testSubmitCreditCardFullyDeductible
CRM_Contribute_Form_ContributionTest.testSubmitCreditCardWithBillingAddress
CRM_Contribute_Form_ContributionTest.testSubmitCreditCardWithNoBillingAddress
CRM_Contribute_Form_ContributionTest.testPremiumUpdateCreditCard
CRM_Contribute_Form_ContributionTest.testCardTypeAndPanTruncationLiveMode
CRM_Core_Payment_AuthorizeNetIPNTest.testIPNPaymentRecurNoReceipt
CRM_Core_Payment_AuthorizeNetIPNTest.testIPNPaymentRecurSuccess
CRM_Core_Payment_AuthorizeNetIPNTest.testIPNPaymentRecurSuccessMultiAuthNetProcessor
CRM_Core_Payment_AuthorizeNetIPNTest.testIPNPaymentRecurSuccessSuppliedReceiveDate
CRM_Core_Payment_AuthorizeNetIPNTest.testIPNPaymentMembershipRecurSuccess
CRM_Core_Payment_AuthorizeNetIPNTest.testIPNPaymentMembershipRecurSuccessNoLeakage
CRM_Core_Payment_AuthorizeNetIPNTest.testIPNPaymentMembershipRecurSuccessNoLeakageOnlineThenOffline
CRM_Core_Payment_PayPalIPNTest.testInvoiceSentOnIPNPaymentSuccess
CRM_Core_Payment_PayPalIPNTest.testIPNPaymentRecurSuccess
CRM_Core_Payment_PayPalIPNTest.testIPNPaymentMembershipRecurSuccess
CRM_Core_Payment_PayPalIPNTest.testIPNPaymentInputMembershipRecurSuccess
CRM_Core_Payment_PayPalIPNTest.testhookAlterIPNDataOnIPNPaymentSuccess
CRM_Core_Payment_PayPalIPNTest.testPayPalIPNSuccessDeletedContact
CRM_Core_Payment_PayPalProIPNTest.testIPNPaymentRecurSuccess
CRM_Core_Payment_PayPalProIPNTest.testIPNPaymentMembershipRecurSuccess
CRM_Core_Payment_PayPalProIPNTest.testIPNPaymentCRM13743
CRM_Member_BAO_MembershipTest.testMembershipPaymentForSingleContributionMultipleMembership

@eileenmcnaughton eileenmcnaughton deleted the processor branch September 6, 2020 01:25
eileenmcnaughton added a commit to eileenmcnaughton/civicrm-core that referenced this pull request Sep 6, 2020
@eileenmcnaughton
[REF] simplify interaction with objects in complete order
6e8a648 
Per civicrm#18382 this line seems to be heavily tested so
& per the test we can use the 'already calculated value' for payment_processor_id rather than look
it up in yet another place.

This adds a query but in most cases queries can be removed before calling this function as
the various objects are not really accessed anymore (apart from the few lines just above this)
eileenmcnaughton added a commit to eileenmcnaughton/civicrm-core that referenced this pull request Sep 6, 2020
@eileenmcnaughton
[REF] simplify interaction with objects in complete order
62a721e 
Per civicrm#18382 this line seems to be heavily tested so
& per the test we can use the 'already calculated value' for payment_processor_id rather than look
it up in yet another place.

This adds a query but in most cases queries can be removed before calling this function as
the various objects are not really accessed anymore (apart from the few lines just above this)
@eileenmcnaughton eileenmcnaughton mentioned this pull request Sep 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eileenmcnaughton