Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated ids param #18375

Merged
merged 1 commit into from
Sep 5, 2020
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Sep 5, 2020

Overview

Remove param that has been noisily deprecated for 8 months & discouraged for much longer

Before

Screen Shot 2020-09-05 at 4 02 10 PM

Screen Shot 2020-09-05 at 4 05 21 PM

After

poof

Technical Details

We've been really clear for a long time that the way to do this from outside core is via the api so we don't need to worry too much about extensions that missed the warning

Comments

@civibot
Copy link

civibot bot commented Sep 5, 2020

(Standard links)

@civibot civibot bot added the master label Sep 5, 2020
@seamuslee001
Copy link
Contributor

Jenkins re test this please

@eileenmcnaughton
Copy link
Contributor Author

unrelated fail

@eileenmcnaughton eileenmcnaughton merged commit 1901c9a into civicrm:master Sep 5, 2020
@eileenmcnaughton eileenmcnaughton deleted the dep branch September 5, 2020 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants