Use eventID rather than the object in completeTransaction #18358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to stop passing it in as an object as a follow up. It potentially does an extra query but this is mitigated by 1) it only does a look up if the contribution does not already have a source (rare) 2) it uses a pseudoconstant so would only look up a given event once - we can later remove the whole loading of event and just get the id from the participant record
|
(Standard links)
|
|
This looks fine to me |
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Sep 5, 2020
This is a follow on to civicrm#18358 - after thinking more I realised that I had already established this code is rarely reached and by doing a very small query when it is we can avoid loading the whole event to pass in Same test applies...
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Sep 5, 2020
This is a follow on to civicrm#18358 - after thinking more I realised that I had already established this code is rarely reached and by doing a very small query when it is we can avoid loading the whole event to pass in Same test applies...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This allows us to stop passing it in as an object as a follow up. It potentially does an extra query but this is
mitigated by
Before
passed around
After
just the id passed around
Technical Details
Comments