dev/core#1936 Make the label field on price_field_value non required …

[seamuslee001]

…field

Overview

5.27 port of #18123

Before

Label field required

After

label field non required

ping @KarinG @demeritcowboy @eileenmcnaughton

Karin in your testing you should update the upgrade function to be 5_27_4 but we need 5_27_5 for core because that will be the next available version

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[KarinG]

I still can not upgrade -> I still get stuck on [Executed: Upgrade DB to 5.27.4: SQL]

[11-Aug-2020 10:40:48 America/Edmonton] Error: Call to undefined method CRM_Core_I18n::getMultilingual() in /Applications/MAMP/htdocs/d8civicrm.local/vendor/civicrm/civicrm-core/CRM/Upgrade/Incremental/php/FiveTwentySeven.php on line 92 #0 /Applications/MAMP/htdocs/d8civicrm.local/vendor/civicrm/civicrm-core/CRM/Queue/Task.php(74): CRM_Upgrade_Incremental_php_FiveTwentySeven::priceFieldValueLabelNonRequired(Object(CRM_Queue_TaskContext))

[KarinG]

Re-ran it with xdebug:

[KarinG]

Notes $locales are fetched differently for public function priceFieldValueLabelRequired($ctx) {

    $domain = new CRM_Core_DAO_Domain();
    $domain->find(TRUE);
    if ($domain->locales) {
      $locales = explode(CRM_Core_DAO::VALUE_SEPARATOR, $domain->locales);

[seamuslee001]

thanks @demeritcowboy @KarinG fixed the upgrader now

[demeritcowboy]

I think you need to explode/unserialize the locales as @KarinG notes, as in CRM_Core_I18n::getMultilingual()

[seamuslee001]

thanks @demeritcowboy fixed now

[KarinG]

Ok one more time! :-)

Installed 5.27.4 - vanilla - create Contribution Page -> reproducing the issue:

Ok then:

karins-MBP:civicrm-core sysadmin$ curl https://patch-diff.githubusercontent.com/raw/civicrm/civicrm-core/pull/18124.diff -o 18124.diff

karins-MBP:civicrm-core sysadmin$ cat 18124.diff |patch -p1
patching file CRM/Core/I18n/SchemaStructure.php
patching file CRM/Price/DAO/PriceFieldValue.php
patching file CRM/Upgrade/Incremental/php/FiveTwentySeven.php
patching file Civi/Api4/Service/Spec/Provider/PriceFieldValueCreationSpecProvider.php
patching file tests/phpunit/CRM/Price/BAO/PriceFieldValueTest.php
patching file xml/schema/Price/PriceFieldValue.xml
karins-MBP:civicrm-core sysadmin$

For testing the upgrade
set civicrm_domain.version = 5.27.3

emacs CRM/Upgrade/Incremental/php/FiveTwentySeven.php
change -> public function upgrade_5_27_5($rev) {
to: public function upgrade_5_27_4($rev) {

Ok here we go - running upgrade -> Done!

Checking:

This looks good:

and this looks good too:

[seamuslee001]

going to add Merge on pass based on @KarinG 's testing on the linked PRs

[seamuslee001]

Test fails unrelated

[KarinG]

Phew!

[eileenmcnaughton]

Thanks @seamuslee001 - the approach had been agreed on chat & I agree @KarinG's testing was solid on this