dev/cloud-native#16 Migrate Contribution Page widget extern url to us…

[seamuslee001]

…e the normal CMS routing mechanism

Overview

This migrates the Contribution Page Widget js end to use an endpoint within the normal routing system

Before

extern file used

After

Non extern route used

ping @eileenmcnaughton @totten @kcristiano

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[totten]

I haven't tested, but the broad contours look good. 👍

[seamuslee001]

@eileenmcnaughton @totten I have expanded the test coverage here to cover both endpoints which shows we are getting a consitatnt return from both endpoints, Is there anything else needed to prove that this works?

[eileenmcnaughton]

I was kinda hoping @kcristiano would test it...

[kcristiano]

did an r-run.

Without the PR:

script:

<script type="text/javascript" src="http://wpcvmaster.test/wp-content/plugins/civicrm/civicrm/extern/widget.php?cpageId=1&widgetId=1&format=3"></script>

With the PR:

Script:

<script type="text/javascript" src="http://wpcvmaster.test/civicrm/contribute/widget/?cpageId=1&widgetId=1&format=3"></script>

Widget looks off:

[seamuslee001]

Did you rebuild the menu Kevin?

…

On Tue, 18 Aug 2020 at 4:49 am, Kevin Cristiano ***@***.***> wrote: did an r-run. Without the PR: [image: image] <https://user-images.githubusercontent.com/1892544/90432520-a5d3e680-e098-11ea-8df2-4565f8f9282a.png> script: <script type="text/javascript" src="http://wpcvmaster.test/wp-content/plugins/civicrm/civicrm/extern/widget.php?cpageId=1&widgetId=1&format=3"></script> With the PR: Script: <script type="text/javascript" src="http://wpcvmaster.test/civicrm/contribute/widget/?cpageId=1&widgetId=1&format=3"></script> Widget looks off: [image: image] <https://user-images.githubusercontent.com/1892544/90432591-c2701e80-e098-11ea-9f09-87c9a29ad905.png> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#17969 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABT36FKUGRES6ZRDHJD7C2DSBF3TFANCNFSM4PII5K2Q> .

[kcristiano]

I did, and cleared caches.

[seamuslee001]

@kcristiano I rebased this and re-tested and after clearing menu cache my url was http://wp-demo/civicrm/contribute/widget/?cpageId=1&widgetId=1&format=3 and the widget looked like the attached in the preview

Are you able to re-test?

[kcristiano]

@seamuslee001 I'll do this, it may take a few days, but I'll give you feedback.

[kcristiano]

@seamuslee001 sorry for the delay but I cannot get the patch to apply on d7 master or wp master. Can you rebase?

[seamuslee001]

@kcristiano rebased now for you mate

[kcristiano]

@seamuslee001 I did a new r-run Preview is good and on remote site:

Contribution works directing me to real form.

Tested on:

WP 5.5.1
CiviCRM master
php 7.3

Looks good to merge.

[eileenmcnaughton]

boom