[REF] Minor code cleanup #17225
Merged
[REF] Minor code cleanup #17225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
colemanw
reviewed
May 3, 2020
| CRM_Utils_Array::value('name', $v, '') == 'image_URL' || | ||
| CRM_Utils_Array::value('field_type', $v) == 'Formatting' | ||
| ) { | ||
| $v['data_type'] ?? '' === 'File' || $v['name'] ?? '' === 'image_URL' || $v['field_type'] === 'Formatting') { |
There was a problem hiding this comment.
When I first looked at this, I thought the precidence of the ?? operators and the === operators might be ambiguous and we should add parentheses.
On second look, I see that the array data is coming from CRM_Core_BAO_UFGroup::getFields which runs every item through CRM_Core_BAO_UFGroup::formatUFField which ensures that data_type, name, and field_type keys are always present. So I don't think the coalesce is needed and this is just another historical artifact of our developers' love-affair with CRM_Utils_Array::value() using it places where it isn't needed, "just because".
There was a problem hiding this comment.
ohh - let's remove!
Do not pass params as reference as unchanged
eileenmcnaughton
commented
May 3, 2020
| CRM_Utils_Array::value('name', $v, '') == 'image_URL' || | ||
| CRM_Utils_Array::value('field_type', $v) == 'Formatting' | ||
| ) { | ||
| $v['data_type'] === 'File' || $v['name'] === 'image_URL' || $v['field_type'] === 'Formatting') { |
There was a problem hiding this comment.
@colemanw tada
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Do not pass params as reference as unchanged
Before
function takes &$params,
After
function takes $params, other minor cleanups
Technical Details
Comments