Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#1460 - Small cleanups in CiviEventDispatcher{,Test} #17216

Merged
merged 2 commits into from
May 2, 2020

Conversation

totten
Copy link
Member

@totten totten commented May 1, 2020

Overview

This is a follow-up to the recently merged #17127 to address a couple small issues.

Before

After

  • The unit test CiviEventDispatcherTest passes in more PHP environments.
  • Some of the docblocks in CiviEventDispatcher have type-info but don't have "summary" lines.

@civibot civibot bot added the master label May 1, 2020
@civibot
Copy link

civibot bot commented May 1, 2020

(Standard links)

@colemanw
Copy link
Member

colemanw commented May 2, 2020

Test failures are unrelated.

@colemanw colemanw merged commit 36e8f22 into civicrm:master May 2, 2020
@totten totten deleted the master-disp-cleanup branch December 14, 2020 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants