Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show title on status message instead machine name #17174

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

pradpnayak
Copy link
Contributor

Overview

When a dedupe rule is used to find duplicate contacts, if no duplicates found then it pops up with message 'No possible duplicates were found using [Rule Name] rule.', Some times machine and title differ and creates confusion to user when they see this message.

This PR provides fix to use title of rule instead name
Output:
'No possible duplicates were found using [Rule Title] rule.'

Before

before

After

after

@civibot
Copy link

civibot bot commented Apr 27, 2020

(Standard links)

@civibot civibot bot added the master label Apr 27, 2020
@colemanw
Copy link
Member

This looks good. I verified that the variable $ruleGroupName isn't being used elsewhere, so there shouldn't be any side-effects.

@colemanw colemanw merged commit 2741a56 into civicrm:master Apr 27, 2020
@pradpnayak pradpnayak deleted the ruleTitle branch June 5, 2020 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants