[REF] Minor cleanup around action schedule code. #17151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
CRM/Core/BAO/ActionSchedule.php
Outdated
| */ | ||
| public static function buildRecipientContacts($mappingID, $now, $params = []) { | ||
| public static function buildRecipientContacts(int $mappingID, $now, $params = []) { |
There was a problem hiding this comment.
fn is only called from one place
eileenmcnaughton
force-pushed
the
actsched
branch
from
4133f5c to
84f6779
Compare
|
@eileenmcnaughton can you please rebase, This looks fine otherwise |
CRM_Core_BAO_ActionSchedule::processQueue is only called from one place. It either succeeds or throws an exception so there is no value in returning anything & the parsing of what it does return assumes that it could return false Some slight tightenig around typing as buildRecipientContact is also only called from one place
eileenmcnaughton
force-pushed
the
actsched
branch
from
84f6779 to
2e9914a
Compare
|
test this please |
|
test this please |
|
Test failures unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor code cleanup
Before
CRM_Core_BAO_ActionSchedule::processQueue is only called from one place. It either succeeds or throws
an exception & the construction of a return array & handling of that array is just meaningless code
After
No return value & lack of exception is understood as success.
Technical Details
Some additional fixes around declared return types & exceptions & using strict typing
Comments