Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev/core#1723 - Adv Search - Reciprocal relationship search with custom fields leads to error #17134

Merged
merged 1 commit into from
Apr 22, 2020
Merged

dev/core#1723 - Adv Search - Reciprocal relationship search with custom fields leads to error #17134

merged 1 commit into from
Apr 22, 2020

Conversation

jitendrapurohit
Copy link
Contributor

@jitendrapurohit jitendrapurohit commented Apr 21, 2020 •
edited by totten
Loading

Backport of #17132 to 5.25 RC.

Overview

Reciprocal relationship search with custom fields leads to an error on Advanced search

Before

See steps to replicate on gitlab - https://lab.civicrm.org/dev/core/-/issues/1723

image

After

Search results are loaded correctly.

Comments

Gitlab - https://lab.civicrm.org/dev/core/-/issues/1723

relates to changes done in #15793

@civibot
Copy link

civibot bot commented Apr 21, 2020

(Standard links)

@civibot civibot bot added the 5.25 label Apr 21, 2020
@jitendrapurohit jitendrapurohit mentioned this pull request Apr 21, 2020
Closed
@seamuslee001
Copy link
Contributor

@jitendrapurohit test fail looks related, my thinking is maybe the test isn't cleaning up properly after its self @eileenmcnaughton ?

@totten totten changed the title RC fix for #17132 dev/core#1723 - Adv Search - Reciprocal relationship search with custom fields leads to error Apr 22, 2020
RC fix for civicrm#17132
804261a 
unit test fix
@seamuslee001
Copy link
Contributor

Added Merge on pass as I am confident we have good unit test coverage here

@seamuslee001
Copy link
Contributor

Test Failure unrelated

@seamuslee001 seamuslee001 merged commit 28d4527 into civicrm:5.25 Apr 22, 2020
@eileenmcnaughton
Copy link
Contributor

thanks @jitendrapurohit and @seamuslee001

@seamuslee001 seamuslee001 mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seamuslee001 seamuslee001 seamuslee001 left review comments

Assignees
No one assigned
Labels
5.25 merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jitendrapurohit @seamuslee001 @eileenmcnaughton