Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/mail#62 - Mailing Error when civicrm_mailing_group has duplicate … #17130

Merged
merged 1 commit into from
May 4, 2020

Conversation

jitendrapurohit
Copy link
Contributor

…entries of recipient groups

Overview

Mailing Error when civicrm_mailing_group has duplicate entries of recipient groups

Before

Details on Gitlab - https://lab.civicrm.org/dev/mail/-/issues/62

image

After

max length of group_concat error is avoided by removing duplicate ids in it. The mailing is loaded and sent correctly.

Technical Details

The group_concat is still an issue if number of groups are more. But maybe, its too rare to include more than >250 groups in a single mailing? Assuming each group id is 2-3 char long with , separating them in group_concat.

Comments

Gitlab - https://lab.civicrm.org/dev/mail/-/issues/62

@civibot
Copy link

civibot bot commented Apr 21, 2020

(Standard links)

@civibot civibot bot added the master label Apr 21, 2020
@seamuslee001
Copy link
Contributor

Change makes sense and looks fine to me merging

@seamuslee001 seamuslee001 merged commit c90aa71 into civicrm:master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants