Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Minor var simplification #17121

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Slight code clarification

Before

Determination of $update less explicit

After

Defined once, an else used later

Technical Details

@mattwire this is pretty minor but I spotted it looking at your proposal. Note I brought in a couple of small changes from yours to reduce the code in any one change

Comments

@civibot
Copy link

civibot bot commented Apr 20, 2020

(Standard links)

@civibot civibot bot added the master label Apr 20, 2020
@colemanw colemanw merged commit 0433122 into civicrm:master Apr 21, 2020
@colemanw colemanw deleted the update branch April 21, 2020 00:10
@colemanw
Copy link
Member

Merging based on code review & passing tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants