Replace CaseType's own XML encoding function #17100
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is detailed at https://lab.civicrm.org/dev/core/-/issues/1719
In a nutshell:
Creating a case type crashes if the
name
of a case status is not valid XML content. e.g. if a name has&
in it, but other special characters would also cause problems.It dies because it fails to properly encode the value.
It uses its own encoding functions instead of a proper XML encoder.
This PR:
replaces the homespun XML encoder with php's own built in one, and properly encodes everything.
adds a test fixture for the case that
&
is in a status name.As a side effect, I believe it fixes 1719