Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused parameter from function #17098

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Remove unused parameter from function #17098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions CRM/Admin/Page/Job.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,10 +136,8 @@ public function run() {

/**
* Browse all jobs.
*
* @param null $action
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's almost like foreshadowing that the variable was declared as type null...

Anyway, agreed the parameter isn't used in either function.

*/
public function browse($action = NULL) {
public function browse() {
// check if non-prod mode is enabled.
if (CRM_Core_Config::environment() != 'Production') {
CRM_Core_Session::setStatus(ts('Execution of scheduled jobs has been turned off by default since this is a non-production environment. You can override this for particular jobs by adding runInNonProductionEnvironment=TRUE as a parameter.'), ts("Non-production Environment"), "warning", array('expires' => 0));
Expand Down
5 changes: 1 addition & 4 deletions CRM/Admin/Page/JobLog.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,8 @@ public function run() {

/**
* Browse all jobs.
*
* @param null $action
*/
public function browse($action = NULL) {

public function browse() {
$jid = CRM_Utils_Request::retrieve('jid', 'Positive', $this);

$sj = new CRM_Core_JobManager();
Expand Down