Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] SavedSearch - additional cleanup & bugfixes #17090

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

colemanw
Copy link
Member

Overview

Followup on #17003 - does some cleanup and refactoring to improve SaveSearch code.

Before

Alter queries using string manipulation.

After

Use class methods to alter queries.

@civibot
Copy link

civibot bot commented Apr 16, 2020

(Standard links)

@civibot civibot bot added the master label Apr 16, 2020
@eileenmcnaughton
Copy link
Contributor

I went though the code & all the changes make sense.

I also tested creating a custom search smart group & a search builder smart group and in each case I was successfully able to take an action on the group's participants

@eileenmcnaughton eileenmcnaughton merged commit a917404 into civicrm:master Apr 17, 2020
@eileenmcnaughton eileenmcnaughton deleted the ssCleanup branch April 17, 2020 02:22
@colemanw
Copy link
Member Author

@eileenmcnaughton thanks for the review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants