Export: use X icon fa-times
for closing things
#17076
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://docs.civicrm.org/dev/en/latest/framework/ui/#icon-meaning-and-consistency
Overview
The button to return to search from choosing export fields should be
fa-times
(an ❌) rather thanfa-ban
(a 🚫)Before
🚫
After
❌
Technical Details
See https://docs.civicrm.org/dev/en/latest/framework/ui/#icon-meaning-and-consistency for a reference on this.
The rationale (besides ❌ being used everywhere already) is that 🚫 implies you want to nix something while ❌ has the connotation of just wanting to get out of where you are.