Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export: use X icon fa-times for closing things #17076

Merged
merged 1 commit into from
Apr 15, 2020

Conversation

agh1
Copy link
Contributor

@agh1 agh1 commented Apr 14, 2020

See https://docs.civicrm.org/dev/en/latest/framework/ui/#icon-meaning-and-consistency

Overview

The button to return to search from choosing export fields should be fa-times (an ❌) rather than fa-ban (a 🚫)

Before

🚫
image

After


image

Technical Details

See https://docs.civicrm.org/dev/en/latest/framework/ui/#icon-meaning-and-consistency for a reference on this.

The rationale (besides ❌ being used everywhere already) is that 🚫 implies you want to nix something while ❌ has the connotation of just wanting to get out of where you are.

@civibot
Copy link

civibot bot commented Apr 14, 2020

(Standard links)

@civibot civibot bot added the master label Apr 14, 2020
@mattwire
Copy link
Contributor

Yay! Consistency :-)

@mattwire mattwire merged commit 67d84fb into civicrm:master Apr 15, 2020
@agh1 agh1 deleted the cancelnotban branch April 15, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants