APIv4 - Fix setting offset with no limit #17063
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a bug in APIv4 where setting an offset with no limit would return no results.
Before
If offset is given, but no limit, 0 results returned.
After
Correct number of results returned.
Technical Details
The API treats 0 as "no limit" but mysql does not.
This implements setting an offset with no limit by applying the maximum possible row count, as mysql does not allow
LIMIT NULL
.See https://stackoverflow.com/questions/255517/mysql-offset-infinite-rows