Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] APIv4 Explorer - improve performance #17062

Merged
merged 3 commits into from
Apr 16, 2020
Merged

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Apr 13, 2020

Overview

Some performance enhancements to the APIv4 explorer. Shouldn't affect functionality.

Before

Slower

After

Faster

Technical Details

Uses one-time bindings, simpler loops, and fewer watches. Avoids populating content that isn't visible (e.g. in a tab that's not currently selected).

@civibot
Copy link

civibot bot commented Apr 13, 2020

(Standard links)

@civibot civibot bot added the master label Apr 13, 2020
@colemanw
Copy link
Member Author

This is gonna cause merge conflicts so I'm merging; this only affects the explorer, I've tested it a bunch, and if there are any problems I'll fix em.

@colemanw colemanw merged commit 1350b40 into civicrm:master Apr 16, 2020
@colemanw colemanw deleted the apiExpPerf branch April 16, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant