[REF] move all functions associated with the submit function onto the Trait #17057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
changed the title
|
Makes sense. Refactor looks good. |
eileenmcnaughton
force-pushed
the
email3
branch
from
92e0f19 to
e54c0a9
Compare
|
test fail relates |
eileenmcnaughton
force-pushed
the
email3
branch
from
e54c0a9 to
704696b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[REF] move all functions associated with the submit function onto the Trait
Before
Email forms call static functions on CRM/Contact/Form/Task/EmailCommon
After
The functions are deprecated & duplicated onto the shared trait
Technical Details
Using the trait makes it much clearer what is defined / what functions are available to the forms as we can move the properties and functions required for email to the forms.
They are left on the EmailCommon class for a little bit in case of unsupported use of it by extensions
Comments