Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#1696 - Update attachment message on mailing form. #17024

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

jitendrapurohit
Copy link
Contributor

@jitendrapurohit jitendrapurohit commented Apr 8, 2020

Overview

Update attachment message on mailing form.

Before

See details on https://lab.civicrm.org/dev/core/-/issues/1696

image

After

Message updated on mailing screen.

image

Comments

Gitlab - https://lab.civicrm.org/dev/core/-/issues/1696

@civibot
Copy link

civibot bot commented Apr 8, 2020

(Standard links)

@civibot civibot bot added the master label Apr 8, 2020
ang/crmAttachment.js Outdated Show resolved Hide resolved
@jitendrapurohit jitendrapurohit force-pushed the core-1696 branch 3 times, most recently from 274a004 to 4e01376 Compare April 9, 2020 09:38
@mattwire
Copy link
Contributor

mattwire commented Apr 9, 2020

@jitendrapurohit @demeritcowboy At the risk of being a pain :-) I'd prefer just adding the "Each file must be less than 3M in size." That part is useful because it is factual - something will either work or won't work, depending on the server config.
The other bit, uploading somewhere else, to google drive etc. is company policy that will be different in each case. And for some orgs uploading somewhere outside of organisation control will be a violation of their data protection policy.

@jitendrapurohit
Copy link
Contributor Author

cool, I've simply removed the extra unwanted line :)

image

@mattwire
Copy link
Contributor

mattwire commented Apr 9, 2020

Great, if @demeritcowboy confirms I will merge

@demeritcowboy
Copy link
Contributor

Yes you're right it's better without the extra wording.

And now @jitendrapurohit you are a trendsetter with the first core api4 js call outside of api4 itself!

Looks good.

@seamuslee001 seamuslee001 merged commit 7f3b351 into civicrm:master Apr 9, 2020
@jitendrapurohit jitendrapurohit deleted the core-1696 branch April 13, 2020 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants