Allow setting metadata to use the table option. Update example setting default_invoice_page.
#16903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-dev-docs
that referenced
this pull request
Mar 26, 2020
|
test this please |
|
@eileenmcnaughton can you rebase please |
This extends the ways in which a pseudoconstant can be defined in a setting to better reflect the ways that work for the DAO objects. In this one field is converted - default_invoice_page under CiviContribute settings. (Described as Default invoice payment page) The expected result is that the options in that page load the same as before. This change will reduce the temptation to call silly core functions from extensions....
eileenmcnaughton
force-pushed
the
settting_better
branch
from
ab9ee9a to
356013b
Compare
|
@seamuslee001 rebased |
|
@eileenmcnaughton I'm going to say the test fails relate |
|
test this please |
|
@seamuslee001 interestingly the same errors were present on https://github.com/civicrm/civicrm-core/pull/16885/files. I didn't manage to reproduce locally so I'm not too sure what's going on |
|
@seamuslee001 looks like it wasn't this PR! |
|
docs PR for this is approved - please adjust the labels if you can when this is merged - and assign the appropriate |
totten
changed the title
table option. Update example setting default_invoice_page.
seamuslee001
approved these changes
Apr 9, 2020
homotechsual
added a commit
to civicrm/civicrm-dev-docs
that referenced
this pull request
May 19, 2020
Update to reflect civicrm/civicrm-core#16903
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
A setting may specify a list of acceptable options (
pseudoconstant). This PR adds another mechanism (table) for defining that list, and it specifically updates one setting (default_invoice_page) to use the new mechanism.The mechanism matches an equivalent mechanism available in DAO fields.
See also, developer documentation: civicrm/civicrm-dev-docs#784
Before
The setting
default_invoice_pagein CiviContribute displays a list of contribution pages:The list is generated by a
callbackfunction (which performs the DB queries).After
The setting
default_invoice_pagein CiviContribute settings displays the same list of contribution pages.However, the
callbackmetadata is replaced withtablemetadata.Technical Details
This change will reduce the temptation to call silly core functions from extensions....
Comments
Builds off #16902