Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add privacy fields to ContributionDetail report #16674

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Add privacy fields to ContributionDetail report #16674

merged 1 commit into from
Mar 23, 2020

Conversation

alexymik
Copy link
Contributor

@alexymik alexymik commented Mar 3, 2020

Add all privacy fields as columns on the Member Contribution Detail report

Before

Do Not Email

After

Do Not Phone
Do Not Email
Do Not Mail
Do Not SMS
Do Not Trade

@civibot
Copy link

civibot bot commented Mar 3, 2020

(Standard links)

@civibot civibot bot added the master label Mar 3, 2020
Add other privacy fields as columns on the Member Contribution Detail report
@seamuslee001
Copy link
Contributor

This looks good to me

@MegaphoneJon
Copy link
Contributor

I think the move has been to use $this->getColumns('Contact') instead of adding columns to reports on a case-by-case basis. #16458 is a similar PR for inspiration.

@jaapjansma
Copy link
Contributor

test this please

@jaapjansma
Copy link
Contributor

  • General standards
    • Explain (r-explain)
      • PASS : The goal/problem/solution have been adequately explained in the PR.
    • User impact (r-user)
      • PASS: The change would be intuitive or unnoticeable.
    • Documentation (r-doc)
      • PASS: The changes do not require documentation.
    • Run it (r-run)
      • PASS: We have tested this with and without this PR on the Membership and Contribution detail report and the columns are available and working.
  • Developer standards
    • Technical impact (r-tech)
      • PASS: The change preserves compatibility with existing callers/code/downstream.
    • Code quality (r-code)
      • PASS: The functionality, purpose, and style of the code seems clear+sensible.
    • Maintainability (r-maint)
      • PASS: The change is trivial enough that it does not require tests.
    • Test results (r-test)
      • PASS: The test results are all-clear.

@mattwire or @eileenmcnaughton could you merge this PR?

@mattwire mattwire merged commit 7cecaec into civicrm:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants