Update recently-added PathUrlTest to be more representative #16607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before ------ The test generates the URL for an example page (`civicrm/mailing/subscribe`) by calling `url()`. It does not explicitly set the `url(...$frontend...)` option, so it defaults to `FALSE`. By contrast, the other places which make URLs for `civicrm/mailing/subscribe` (eg `CRM/Mailing/BAO/Mailing.php` and `CRM/Utils/Token.php`) do set `$frontend` to `TRUE`. After ----- The test behaves the same way as other code.
|
(Standard links)
|
|
this makes sense |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
The test generates the URL for an example page (
civicrm/mailing/subscribe)by calling
url(). It does not explicitly set theurl(...$frontend...)option,so it defaults to
$frontend=FALSE.By contrast, the other places which make URLs for
civicrm/mailing/subscribe(eg
CRM/Mailing/BAO/Mailing.phpandCRM/Utils/Token.php) do pass$frontend=TRUE.After
The test behaves the same way as other code (i.e. passing
$frontend=TRUE).Comments
This issue was noticed while debugging this E2E test on WP (which has been failing). This plausibly would cause problems with the correctness of the test on WP/J, although (in my local testing so far) I don't think this actually fixes things. But it's still good to address.