Fix theoretical regression #16567
Merged
Fix theoretical regression #16567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR civicrm@44237a2 (merged to 5.23) calls self::::getDefaultRoleID() in a way that was always flawed but definitely woudl not work now. I think it is never reached but better to put this fix into 5.23 & maybe reemove the line in master later since it assumes participant_status_id is optional - which is not true of the backoffice form
|
(Standard links)
|
|
Change looks fine to me merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes an instance where an invalid function is called - in a place I believe to be unreachable
Before
self::getDefaultRoleID() called
After
CRM_Event_BAO_Participant::getDefaultRoleID()
Technical Details
This PR 44237a2
(merged to 5.23) calls self::::getDefaultRoleID() in a way that was always flawed (because it was private) but definitely would
not work now. I think it is never reached but better to put this fix into 5.23 & maybe reemove the line in master
later since it assumes participant_status_id is optional - which is not true of the backoffice form
Comments