dev/mail#59 - Fix use of useXOAUTH2 constant instead of var #16518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where a missing $ before the useXOAUTH2 variable prevents IMAP authentication with XOAUTH2 from working.
|
(Standard links)
|
|
D'oh |
|
Test fail unrelated but agree with this merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fixes an issue where a missing
$before theuseXOAUTH2variable prevents IMAP authentication with XOAUTH2 from working.Before
XOAUTH2 IMAP authentication is not working because the if is never entered.
After
XOAUTH2 IMAP authentication works.