Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] throw exceptions, single quotes, declare exceptions, remove unused param #16415

Merged
merged 1 commit into from
Jan 29, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Minor cleanup to known conventions

Before

  • exceptions not declared
  • non-strict checking used when one side is clearly a string
  • a mis-cased function call
  • double quotes when a single will do
  • a function takes a parameter & entirely ignores it. This class is not extending anything

After

Above fixed

Technical Details

All minor stuff - fixing to reduce distractions

Comments

@civibot
Copy link

civibot bot commented Jan 29, 2020

(Standard links)

@civibot civibot bot added the master label Jan 29, 2020
@mattwire mattwire merged commit 46b5cb9 into civicrm:master Jan 29, 2020
@eileenmcnaughton eileenmcnaughton deleted the fatal branch January 29, 2020 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants