Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] Add test for line item, extract fn #16402

Merged
merged 1 commit into from
Jan 30, 2020
Merged

[REF] Add test for line item, extract fn #16402

merged 1 commit into from
Jan 30, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Function extraction, add test

Before

Long chunk

After

This just extracts the inner of the function & adds a test

Technical Details

Comments

@civibot
Copy link

civibot bot commented Jan 28, 2020

(Standard links)

@civibot civibot bot added the master label Jan 28, 2020
@eileenmcnaughton eileenmcnaughton force-pushed the part_test branch 2 times, most recently from ffcfd9c to 078c640 Compare January 29, 2020 01:43
@seamuslee001
Copy link
Contributor

Jenkins re test this please

@seamuslee001
Copy link
Contributor

@eileenmcnaughton style issue https://test.civicrm.org/job/CiviCRM-Core-PR/31762/checkstyleResult/new/

@eileenmcnaughton
Copy link
Contributor Author

thanks @seamuslee001 I've been struggling with weird output on style issues lately

@seamuslee001
Copy link
Contributor

yeh @demeritcowboy found the problem there and i just deployed the fix

@seamuslee001
Copy link
Contributor

test fail looks related @eileenmcnaughton

@eileenmcnaughton
Copy link
Contributor Author

ug

@eileenmcnaughton
Copy link
Contributor Author

unrelated fail

@eileenmcnaughton eileenmcnaughton merged commit 6b058bd into civicrm:master Jan 30, 2020
@eileenmcnaughton eileenmcnaughton deleted the part_test branch January 30, 2020 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eileenmcnaughton @seamuslee001 @mattwire