dev/core#1558 retrieve setting credit_notes_prefix as a 'real' setting. #16397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
cont_setting3
branch
from
754051a to
cba4b6b
Compare
|
@eileenmcnaughton Does this have any related ticket? There are more PR's to come I assume - might be better to have one to make it easier to keep track. |
|
@yashodha added ^^ |
eileenmcnaughton
changed the title
|
@eileenmcnaughton thanks! You might want to rebase and push again. |
eileenmcnaughton
force-pushed
the
cont_setting3
branch
from
cba4b6b to
9b24484
Compare
eileenmcnaughton
changed the title
eileenmcnaughton
force-pushed
the
cont_setting3
branch
from
9b24484 to
9393a45
Compare
|
test this please |
1 similar comment
|
test this please |
This is part of work to convert the non-standard contribution_invoice_settings array of settings into settings in line
with our standards
eileenmcnaughton
force-pushed
the
cont_setting3
branch
from
9393a45 to
fbc465d
Compare
|
This seems to be in line with other related work; code looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is part of work to convert the non-standard contribution_invoice_settings array of settings into settings in line
with our standards
Before
Setting for credit_notes_prefix is now defined, as it's own setting thanks to #16424 but it is still not being retrieved 'the right way'
After
credit_notes_prefix is retrieved the right way
Technical Details
I'm going to convert the other settings too.
Comments
https://lab.civicrm.org/dev/core/issues/1558