Fix tests to use buildFeeFn

[eileenmcnaughton]

Overview

This fixes the tests on the backoffice participant form to use the 'real' function to set up for tests (now we have cleaned up that function a bit). This means the transactions created are now valid and we can lock that in with

 protected function assertPostConditions() {
    $this->validateAllPayments();
  }

Before

Tests are creating invalid transactions due to invalid set up, not tested

After

Valid transactions are tested

Technical Details

I'm working on this for 2 reasons

1. I want to start doing the validation on all tests that create financial entities, I'm already aware that one test that fails when I add this to all tests is a true bug
2. I'm trying to cleanup the back office form to the point where I can use a valid method to set up partial payments & deprecate the hacks in the BAO layer to support our 'first attempt approach' at partial payments - as represented in this form

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Looks good to me adding merge on pass