-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
event#32: Fix bad variable in message template #16367
Conversation
(Standard links)
|
'templates' => [ | ||
['name' => 'contribution_offline_receipt', 'type' => 'text'], | ||
['name' => 'contribution_offline_receipt', 'type' => 'html'], | ||
['name' => 'participant_confirm_html', 'type' => 'html'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MegaphoneJon this should be
['name' => 'participant_confirm', 'type' => 'html'],
instead of
['name' => 'participant_confirm_html', 'type' => 'html'],
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edit: my bad, I misread, sorry!
@MegaphoneJon Fix looks good. In upgrade this should be instead of |
a77fa2b
to
91794ad
Compare
Test fail seems unrelated:
|
jenkins, test this please |
Changes look correct to me merging as per review from @yashodha |
Overview
There's an incorrect variable in the "Confirm Invitation" message template.
Before
Bad URL for self-service updates.
After
Good URL for self-service updates.