Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

event#32: Fix bad variable in message template #16367

Merged
merged 1 commit into from
Jan 27, 2020

Conversation

MegaphoneJon
Copy link
Contributor

Overview

There's an incorrect variable in the "Confirm Invitation" message template.

Before

Bad URL for self-service updates.

After

Good URL for self-service updates.

@civibot
Copy link

civibot bot commented Jan 24, 2020

(Standard links)

@civibot civibot bot added the master label Jan 24, 2020
'templates' => [
['name' => 'contribution_offline_receipt', 'type' => 'text'],
['name' => 'contribution_offline_receipt', 'type' => 'html'],
['name' => 'participant_confirm_html', 'type' => 'html'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MegaphoneJon this should be

['name' => 'participant_confirm', 'type' => 'html'],

instead of
['name' => 'participant_confirm_html', 'type' => 'html'],

Copy link
Member

@mlutfy mlutfy Jan 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edit: my bad, I misread, sorry!

@yashodha
Copy link
Contributor

@MegaphoneJon Fix looks good. In upgrade this should be
['name' => 'participant_confirm', 'type' => 'html'],

instead of
['name' => 'participant_confirm_html', 'type' => 'html'],

@mlutfy
Copy link
Member

mlutfy commented Jan 24, 2020

Test fail seems unrelated:

Test Result (1 failure / +1)
    api.v4.Entity.ConformanceTest.testConformance

@mlutfy
Copy link
Member

mlutfy commented Jan 24, 2020

jenkins, test this please

@seamuslee001
Copy link
Contributor

Changes look correct to me merging as per review from @yashodha

@seamuslee001 seamuslee001 merged commit f1bd5b5 into civicrm:master Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants