Remove unreachable code lines.

[eileenmcnaughton]

Overview

Removes lines of code for setting credit-note-id that were previously identified as unreachable

Before

Lines present - deprecation notices would have been seen if anyone hit them over the last few months (in a dev env or a unit test at least)

After

Lines gone - note that they call a very slow function that we aspire to moving out to an optional extension

Technical Details

We were very precautionary in Barcelona & deprecated rather than removing these line. However, we've had
several releases including a security release & an ESR since then with no one reporting hitting these so
they can go now

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[jitendrapurohit]

Verified by updating the contribution to Refunded/Cancelled using API, Forms, etc. Also tested with the payment API which sets the status of the contribution to refund on negative amount parameter. The credit note id was set correctly in all the cases. Agree with the removal of these code lines.

[yashodha]

@eileenmcnaughton @jitendrapurohit looks good, merging this. Thanks!

[eileenmcnaughton]

thanks @yashodha

[eileenmcnaughton]

& @jitendrapurohit